JulianOzelRose / TR-SaveMaster

A savegame editor for Tomb Raider 1-5 classic. Works with all expansions and bonus levels. Compatible with original, Steam, GOG, and ATI savegames.
7 stars 0 forks source link

Doesn't work with german level names #1

Closed StenApp closed 9 months ago

StenApp commented 9 months ago

Doesn't work with german level names.

I'm using https://github.com/Trxyebeep/tomb3

JulianOzelRose commented 9 months ago

Hi, I just added German level name strings to the editor. The updated binary is here. Let me know if it works.

StenApp commented 9 months ago

It recognizes the level names without umlauts like Tempelruine. Kaliya Höhlen, in hexeditor Kaliya H~ohlen, these savegames are not present in the save game editor.

StenApp commented 9 months ago

TR2 with https://github.com/Arsunt/TR2Main same thing "Die Gro=e Mauer"

"

JulianOzelRose commented 9 months ago

I don't have access to any German savegames. What do the level strings that contain "ü" appear as in a hex editor for TR3?

StenApp commented 9 months ago

I don't have access to any German savegames. What do the level strings that contain "ü" appear as in a hex editor for TR3?

It appears as K~ustendorf

JulianOzelRose commented 9 months ago

Updated for German level names for TR3 and TR2. Let me know if it works.

StenApp commented 9 months ago

TR1

TR2 https://github.com/Arsunt/TR2Main Golden Mask savegame.0 Der kalte Krieg TR3 https://github.com/Trxyebeep/tomb3 Lost artifact different file format? savegame.0.txt

TR4 https://github.com/Trxyebeep/TOMB4 hexvalue Angkor Wat TR5 https://github.com/Trxyebeep/TOMB5 hexvalue Die Strassen von Rom

TR3 has problems with ü and ö

2024-01-23 19_07_00-HxD -  C__Spiele_TR3_saves_savegame 14 2024-01-23 19_07_30-HxD -  C__Spiele_TR3_saves_savegame 6

Is there a way to compile a list with level names in german without playing through every level?

JulianOzelRose commented 9 months ago

TR1

The Golden Mask

TR3

TR4

TR5

For compiling German level names, I just used DE wikis and some YouTube playthroughs. For special characters like umlauts, I made an assumption that they are formatted in the same way as in TR3 ('~' before a character indicates it has umlaut, and '=' indicates 'ß' character) but it may not necessarily work this way, in which case you can provide me with the non-working file(s) and I will adjust it.

For the TLA savegame you provided, it seems to use the same format, but the level strings are a bit different (i.e. "Highlands" instead of "Highland Fling"). If you could provide some more savegames for the other levels, I will make my editor compatible with it.

Lastly, TR1X appears to use a completely different format for its savegames. To support those, you would likely have to build an entirely separate editor specifically for it.

Let me know how this all works, and I will package it as a new release if everything is good.

StenApp commented 9 months ago

Thank you for your hard work, i'm going to test it and report here.

JulianOzelRose commented 9 months ago

Sure thing. I just updated the editor to use the level index instead of level string to determine parameters/offsets, so it should work with any level string/language now. Let me know if it works with GOG and ATI savegames.

StenApp commented 9 months ago

I get a crash if i select the wrong folder for the game tab i opened Crash of picking wrong TR game folder.txt

StenApp commented 9 months ago
JulianOzelRose commented 9 months ago

I patched it to no longer crash when trying to load the wrong directory. If you send me an archive of the GOG/ATI savegame files that aren't displaying for TR1/UB, I can check them out. I have a feeling I know why it's happening.

StenApp commented 9 months ago

Both save file types are stored in root of Tomb Raider 1 ATI Tomb Raider 1 ATI.rar.txt

JulianOzelRose commented 9 months ago

Both save file types are stored in root of Tomb Raider 1 ATI Tomb Raider 1 ATI.rar.txt

Those savegames show up on the editor for me. I made quite a few updates, maybe check that you're using the latest binary.

TR1 TR1UB

StenApp commented 9 months ago

I used the latest now (https://github.com/JulianOzelRose/TR-SaveMaster/commit/0dc28b3581ad6dade5f1a39847a5e09d50087708)

but... 2024-01-26 21_09_16-Greenshot

I installed Gog TR1 and installed TombATI, maybe this makes the difference https://www.glidos.net/tombati.html

JulianOzelRose commented 9 months ago

Ah, I see the problem. The level index of UB saves causes a false positive for TR1 savegames, so I used file size to differentiate them. Try it now, it shouldn't mix TR1 and UB savegames anymore.

StenApp commented 9 months ago

This Version fixes it, thanks! I'm playing TR3 right now, so i think for the first we can close this as done