search

JulianSchmid / etherparse

A rust library for parsing ethernet & ethernet using protocols.
Apache License 2.0
286 stars 54 forks source link

Invalid packet in case of already aligned data - don't added End of Options List #1

Closed agend closed 5 years ago

agend commented 5 years ago

While patching packet for MSS faced invalid packet length - excessive padding. Added test case for this.

codecov[bot] commented 5 years ago

Codecov Report

Merging #1 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   99.53%   99.53%   +<.01%     
==========================================
  Files          21       21              
  Lines        3836     3839       +3     
==========================================
+ Hits         3818     3821       +3     
  Misses         18       18
Impacted Files Coverage Δ
src/transport/tcp.rs 99.59% <ø> (-0.01%) :arrow_down:
tests/transport/tcp.rs 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 775558f...6835038. Read the comment docs.

JulianSchmid commented 5 years ago

Is part of version 0.6.0 (just published).