search

JulianSchmid / etherparse

A rust library for parsing ethernet & ethernet using protocols.
Apache License 2.0
286 stars 54 forks source link

TryFrom for IpNumber #17

Closed skeggse closed 1 year ago

skeggse commented 2 years ago

Just a mild convenience: TryFrom/try_from for u8 -> IpNumber, to avoid having to pull something else in!

JulianSchmid commented 1 year ago

Hi,

Thanks for the PR & sorry that I am so slow to react.

I actually would prefer to replace the IpNumber enum with a simple struct (see https://github.com/JulianSchmid/etherparse/issues/51 ) in a future release. I will update the ticket as soon as this happens.

Greets Julian

JulianSchmid commented 1 year ago

Resolved by https://github.com/JulianSchmid/etherparse/issues/51