JulianSchmid / etherparse

A rust library for parsing ethernet & ethernet using protocols.
Apache License 2.0
286 stars 54 forks source link

Read Error rework #21

Closed JulianSchmid closed 5 months ago

JulianSchmid commented 2 years ago

Resolves #16

codecov[bot] commented 2 years ago

Codecov Report

Merging #21 (2323e4c) into master (82e959c) will decrease coverage by 0.16%. The diff coverage is 98.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   99.68%   99.52%   -0.17%     
==========================================
  Files          45       48       +3     
  Lines       16428    18237    +1809     
==========================================
+ Hits        16377    18150    +1773     
- Misses         51       87      +36     
Impacted Files Coverage Δ
src/lib.rs 100.00% <ø> (+0.45%) :arrow_up:
tests/internet/ip.rs 99.51% <ø> (ø)
tests/packet_decoder/mod.rs 100.00% <ø> (ø)
tests/packet_slicing/mod.rs 98.37% <ø> (ø)
tests/de/mod.rs 97.16% <97.16%> (ø)
tests/errors/mod.rs 98.80% <98.93%> (-0.03%) :arrow_down:
src/errors.rs 99.39% <99.39%> (ø)
src/de.rs 100.00% <100.00%> (ø)
src/internet/ip.rs 100.00% <100.00%> (ø)
src/internet/ip_authentication.rs 100.00% <100.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82e959c...2323e4c. Read the comment docs.

JulianSchmid commented 5 months ago

https://github.com/JulianSchmid/etherparse/releases/tag/v0.14.0 implemented a better version of this change.