IpNumber deriving helpers

JulianSchmid / etherparse

A rust library for parsing ethernet & ethernet using protocols.

Apache License 2.0

286 stars 54 forks source link

IpNumber deriving helpers #30

Closed Voronar closed 5 months ago

Voronar commented 2 years ago

Features:

impl TryFrom<u8> for IpNumber (resolves #17)
impl Iterator for IpNumber

JulianSchmid commented 5 months ago

Thanks for the PR. But I changed the type of IpNumber in https://github.com/JulianSchmid/etherparse/releases/tag/v0.14.0 . It is no longer an enum it is now a struct containing an u8 (struct IpNumber(u8)). Your PR gave me the idea, that an enum was probably a bad idea for that type.

Sorry for not getting back to you for so long & thanks for the PR.