Closed daviessm closed 1 year ago
Hi @daviessm ,
I like it, but I would as you proposed (and did) put it behind a non default feature flag.
Greets Julian
Sorry I forgot: Thanks for the pull request π .
Base: 99.63% // Head: 99.58% // Decreases project coverage by -0.05%
:warning:
Coverage data is based on head (
cb9d36c
) compared to base (05ac511
). Patch coverage: 0.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi @JulianSchmid, thanks for the review! I implemented this because I thought I needed it in a project but ended up writing a custom serializer in my code instead so I won't have any time to work on this any more. I'd be happy for this to be closed or taken over by someone else, whatever works best for you.
Hi @daviessm , then I would take over the PR and implement it.
I moved to branch to this repo and opened up a new PR https://github.com/JulianSchmid/etherparse/pull/45
I had a requirement to serialize packets. What would you think of adding
serde
support to the package, behind a feature flag?