search

JulianSchmid / etherparse

A rust library for parsing ethernet & ethernet using protocols.
Apache License 2.0
304 stars 55 forks source link

[Feature Request] Slice mutating functions #9

Open washley opened 4 years ago

washley commented 4 years ago

First of all, thanks for writing this crate!

It would be pretty awesome if the slice types had functions to modify attributes, and these wrote-through to the underlying slice.

Another optimization that could be made here is that, since we know what's changing, you can perform an optimized checksum recalculation (see https://tools.ietf.org/html/rfc1631 section 3.3).

washley commented 4 years ago

Of course now I see the roadmap, and this is on there. I don't know if you prefer to close this or leave it open, I'll leave that up to you.

thomaseizinger commented 2 months ago

A heads-up that we started to use etherparse with the need to mutate certain parts of the IP header: https://github.com/firezone/firezone/pull/6524/files#diff-5501ead477be03a5eea0d523140b1b4ba2c58647d04b6b1b518e4fd58b31b1df

We plan on upstreaming these eventually.

JulianSchmid commented 2 months ago

Hi @thomaseizinger ,

Great to hear. Just open up a pull request if you are ready.

Greets Julian