Add linux sll support - Githubissues

RabadanDotDev commented 2 months ago

Work mentioned in #97. I implemented the part of the public interface I was most interested in (SlicedPacket::from_linux_sll) and all the additions/extensions to the rest of the code it needed. There are some parts missing, but if you are interested in merging, I can work on them when I get the time.

Specifically, some points missing are:

[ ] Implementation of PacketHeaders::from_linux_sll()
[ ] Implementation of LaxSlicedPacket::from_linux_sll()
[ ] Implementation of LaxPacketHeaders::from_linux_sll()
[ ] Revising the added test code, making sure it makes sense and the relevant cases are covered

JulianSchmid commented 2 months ago

Wow thanks for that PR. I will have a deep look into it tomorrow, but so far it looks incredible.

JulianSchmid commented 2 months ago

I will fix the errors that my no-std fix introduced in the evening.

RabadanDotDev commented 2 months ago

I would merge your PR and move the missing topics you mentioned in the PR description into a ticket. If you find time to implement them a new PR would be very welcome.

Ok perfect, sounds good! When I finish other work I have I'll to look into to finish implementing the rest.

GyulyVGC commented 1 month ago

That's an amazing addition.

Thanks for the work @RabadanDotDev and @JulianSchmid for reviewing ❤️

JulianSchmid / etherparse

Add linux sll support #99