Can't disc swap to disc 1?

JulianoW commented 3 years ago

Reported: https://gbatemp.net/threads/tales-of-symphonia-undub.591460/#post-9615422

Also it is not possible right now to swap from disc2 to disc1. swapping from disc1 to disc2 works but not the other way around for the patched disc1. i have tried with clean isos and only the patched disc1 was the one none of the versions could swap to on dolphin.

Need to look into how disc swap works and try to determine why this is happening.

Nicolas-Miranda commented 2 years ago

Hi @JulianoW, while testing the undub isos. I came up with this bug as I put the clean ISOs along with the undub ones in the same folder in my SD card. I thought it was an issue with Swiss GC and reported the following issue https://github.com/emukidid/swiss-gc/issues/608. Extrems from the Swiss GC team helped me to figure out the actual problem and he mentioned the following:

Turns out there's also this issue: JulianoW/Tales-of-Symphonia-NGC-Undub#2 I've taken a look, and the max FST size specified by disc 2 is too small for the FST of disc 1.

Maybe that can be of help to find the root cause for the crashes after a disc swap.

I also found a crash in the end cinematic from Disc 2.

I hope that information can be of help. I'm still playing the game and will report you any issue I find.

Thank you so very much for all the effort and work you put on this project.

Regards!!

JulianoW commented 2 years ago

Hi @JulianoW, while testing the undub isos. I came up with this bug as I put the clean ISOs along with the undub ones in the same folder in my SD card. I thought it was an issue with Swiss GC and reported the following issue emukidid/swiss-gc#608. Extrems from the Swiss GC team helped me to figure out the actual problem and he mentioned the following:

Turns out there's also this issue: JulianoW/Tales-of-Symphonia-NGC-Undub#2 I've taken a look, and the max FST size specified by disc 2 is too small for the FST of disc 1.

Maybe that can be of help to find the root cause for the crashes after a disc swap.

I also found a crash in the end cinematic from Disc 2.

I hope that information can be of help. I'm still playing the game and will report you any issue I find.

Thank you so very much for all the effort and work you put on this project.

Regards!!

Thank you, I will look into it.

Trixarian commented 9 months ago

Here's how this works:

Dolphin will load the first instance of the game's disc it finds, including the original discs if they appear higher in the list
It'll lockup on the loading disc screen if you try loading a Disc 1 save game while on Disc 2
It'll swap to Disc 2 properly if you load a Disc 2 save game while on Disc 1
Having done the above, if you now load the Disc 1 save game while swapped to Disc 2, it will now swap to Disc 1 properly

The bug seems to be with Disc 2 somewhere, and it resolves itself if the game instance switched to Disc 2 from Disc 1, meaning Disc 2 is probably not loading the Disc 1 instance data properly, while a Swapped to Disc 2 instance does have this data loaded to memory, resolving the bug

JulianoW / Tales-of-Symphonia-NGC-Undub

Can't disc swap to disc 1? #2