Julias0 / sobdo

2 stars 1 forks source link

Move dependencies into package.json, remove hint, bootstrap files and introduce them as installable dependencies #2

Open Julias0 opened 4 months ago

Julias0 commented 4 months ago

Right now dependencies like hint.min.css, bootstrap.min.css are all manually copied inside the repo. A better way to do this would be to load them based on dependencies defined in package.json and load them through references.

Using something simple like gulp or even something like parcel should be enough as a build system

subrat611 commented 4 months ago

@Julias0 could you pls assign this issue to me.

And also have some doubts regarding the bundler, I want to use parcel.js. Should I use this or you want to refer something else.

Julias0 commented 4 months ago

@subrat611 should be fine to use parcel. Let's do it like this -

subrat611 commented 4 months ago

@Julias0 I am having an issue and I need some time to figure it out. I haven't used these build tools before.

I added the parcel.js and generate the build folder but the manifest.json and the rest of the files content scripts were not able to add to the build folder.

{
  "name": "sobdo",
  "version": "1.0.0",
  "description": "Do you read Substack daily?",
  "scripts": {
    "start": "parcel src/popup/html/popup.html --dist-dir build",
    "build": "zip -r build.zip build"
  },
  "author": "Julias0",
  "license": "ISC",
  "devDependencies": {
    "parcel": "2.12.0"
  },
  "dependencies": {
    "bootstrap": "5.3.3",
    "hint.css": "3.0.0"
  }
}
Julias0 commented 3 months ago

Hey, you can create a shell script file which copies the required files before generating the build. Having a setup.sh, run.sh and build.sh is pretty common practice. You can go in the makefile direction too

Julias0 commented 3 weeks ago

Removing assignee since no update