Fix : fastify example - Githubissues

Julien-R44 / hot-hook

🪝 Simple HMR for NodeJS + ESM

MIT License

196 stars 5 forks source link

Fix : fastify example #2

Closed arkerone closed 7 months ago

arkerone commented 7 months ago

Fix the fastify example :

Use the new root option
Remove the throw statement and properly start the Fastify server

Julien-R44 commented 7 months ago

Oops. thanks a lot!

btw, it's still not going to work with the new version. we are missing the import.meta.hot.boundary usage in the import expression. also, we don't need reload anymore too

but I'm currently in the process or reworking the different examples and also the documentation, so no worries, I will handle that

Thanks !

Julien-R44 commented 7 months ago

Please see the readme for the new version: https://github.com/Julien-R44/hot-hook#boundary and also this PR : https://github.com/Julien-R44/hot-hook/pull/1

sorry for this major change only 24 hours after the initial release 😅

the fastify example has also been updated and works correctly let me know if you need any help or have any feedback regarding an integration of hot hook in fastify

arkerone commented 7 months ago

Oops. thanks a lot!

btw, it's still not going to work with the new version. we are missing the import.meta.hot.boundary usage in the import expression. also, we don't need reload anymore too

but I'm currently in the process or reworking the different examples and also the documentation, so no worries, I will handle that

Thanks !

Haha no problem, I'm just testing the module! Great work! :wink: