fix: bad patterns - Githubissues

wonderbeel commented 1 year ago

:wave: I found a couple of issues using this preset recently:

the background-image rule was not working for some patterns (eg, squares-in-squares) because it was matching another pattern and trying to use the rest of the name as a color; ensuring that the patterns are solved in the regex solved this issue, but maybe it can be solved in a better way?
there were a couple of patterns with both a fill='FILLCOLOR' and fill='none' attribute, this was causing that patterns to not work as expected when using a --webkit-mask-image rule because the svg was basically transparent (FILLCOLOR is not a valid color so the browser was fallbacking to the previous color). To fix it I removed the fill='none' attribute and ensured that in the generated css rule we always have a pattern filled with black and opacity of 1 to be sure that we are not depending on a random behavior of the browser to obtain the correct image
I updated the playground to show all the patterns in both modes, this way it is easier to see if something is wrong.

Julien-R44 commented 1 year ago

Awesome thanks a lot.

Would you be interested to get invited as a collaborator on the repo?

wonderbeel commented 1 year ago

If you can add me as a collaborator it would be great, I use this preset a lot for pet projects so I can probably find and fix issues if some upstream updates break it 👀.

Julien-R44 commented 1 year ago

Just added you as a collaborator ! Would be cool if we can still go through PRs for our changes, including me

Thanks a lot dude !!

Julien-R44 / unocss-preset-heropatterns

fix: bad patterns #2