Julien-cpsn / ATAC

A simple API client (postman like) in your terminal
https://atac.julien-cpsn.com/
MIT License
2.02k stars 86 forks source link

Changed "Validate" to "Confirm" to avoid the English language police #70

Closed Julien-cpsn closed 6 months ago

ccoVeille commented 6 months ago

You made me laugh so much with "to avoid English police" 🤣😅😂

Julien-cpsn commented 6 months ago

@ccoVeille haha I said this because I personally know @AirOne01 we are both from Lyon

ccoVeille commented 6 months ago

@ccoVeille haha I said this because I personally know @AirOne01 we are both from Lyon

Villeurbanne, here ! Grand Lyon represents !

Julien-cpsn commented 6 months ago

Yes Villeurbanne too :)

PS : the issue number is 69

airone01 commented 6 months ago

PS : the issue number is 69

LMAO I didn't see that 😂 that's awesome

ccoVeille commented 6 months ago

People who are not from France, won't get the joke, and I will think about dirty things, haha

https://en.wikipedia.org/wiki/Rh%C3%B4ne_(department)

Department number 69

guruor commented 6 months ago

This change caused issue with vim bindings, getting below error when running atac:

Error:
    Could not parse key bindings file
    TOML parse error at line 19, column 1
   |
19 | [keybindings.generic.text_inputs.text_input]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing field `validate`
Julien-cpsn commented 6 months ago

This change caused issue with vim bindings, getting below error when running atac:

Error:
  Could not parse key bindings file
  TOML parse error at line 19, column 1
   |
19 | [keybindings.generic.text_inputs.text_input]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing field `validate`

Hello,

Which version are you using?

guruor commented 6 months ago

Had installed latest version from homebrew:

atac 0.15.1

Using vim bindings file mentioned in repo: https://github.com/Julien-cpsn/ATAC/blob/main/key_bindings_templates/vim_key_bindings.toml

# Collection name, request name, URL, Header, Query param, Basic Auth, Bearer Token
[keybindings.generic.text_inputs.text_input]
cancel = "Esc"
# confirm = "Enter" # -> This is causing issue
validate = "Enter" # -> This fixes issue
Julien-cpsn commented 6 months ago

Hello @G0V1NDS

I understand the issue, the commit that changes "validate" into "confirm" is not released yet but is on the main branch. Since you installed the app with homebrew, you don't have the other files linked to the app, so you got to the main branch, unfortunately it's not the great version of the file!

It's temporary until the new release then! I didn't not think of that

Have a great day

guruor commented 6 months ago

Understood, Anyways I stopped using vim bindings so problem is sorted for now.