search

JulienBreux / phpunit-docker

DEPRECATED :package: Docker image to use PHPUnit as CLI.
https://hub.docker.com/r/phpunit/phpunit/
MIT License
47 stars 28 forks source link

Enable extensions installation from PECL #42

Closed improved-broccoli closed 8 years ago

improved-broccoli commented 8 years ago

I tried to build an image from this one where I installed a PHP extension through PECL. But it failed because PHP is not built with XML in its core. And since PECL runs on top of PHP without any extensions, it gives errors. more information.

Given PECL works great from DockerHub's official PHP Alpine image, I wonder if it would be possible to replace base image (alpine:edge) with DockerHub PHP Alpine image ?

It would improve phpunit image extensibility (by providing ability to install PECL) and make its Dockerfile much cleaner.

JulienBreux commented 8 years ago

Hi @jbenoit2011,

I work hard to change the base image for you!

JulienBreux commented 8 years ago

Ok, I found a solution. (#44)

FROM phpunit/phpunit
MAINTAINER Julien BENOIT <julien.benoit@gmail.com>
ENV PEAR_PACKAGES foo bar baz

smart

JulienBreux commented 8 years ago

@jbenoit2011 okey, build in progress :)

JulienBreux commented 8 years ago

@jbenoit2011 that's ok for you?

improved-broccoli commented 8 years ago

Actually, before I open this issue I workaround the problem by inheriting from another image. But I thought it would be valuable for other people to be aware of this problem. I saw you include PEAR in the image. On my side, I am trying, when I have 5 minutes, to include PECL as well. I will let you know, through a PR, when it will be done.

JulienBreux commented 8 years ago

Nice, hoping you have helped 😃