The base image should be fixed to a specific one, otherwise, with time, it will be impossible to recreate/modify/build this project if the base image changes substantially. For example, at work I'm using version 4.8.5 which has composer/composer as base image and I cannot recreate / modify it, as the actual composer/composer image runs php 7 while the 4.8.5 still runs php 5.5 and docker build fails.
I have also updated the rest of the Dockerfile for master and 6.5.2 to match the latest best practices of Dockerfile: MAINTAINER has been changed to LABEL, the packages have been ordered alphabetically (it is easier to check if a package is missing) and few other improvements.
I have also modified the templates, so that the next versions will keep this format.
Regards
Fabio
JulienBreux
commented
6 years ago
The base image should be fixed to a specific one, otherwise, with time, it will be impossible to recreate/modify/build this project if the base image changes substantially. For example, at work I'm using version 4.8.5 which has composer/composer as base image and I cannot recreate / modify it, as the actual composer/composer image runs php 7 while the 4.8.5 still runs php 5.5 and docker build fails. I have also updated the rest of the Dockerfile for master and 6.5.2 to match the latest best practices of Dockerfile: MAINTAINER has been changed to LABEL, the packages have been ordered alphabetically (it is easier to check if a package is missing) and few other improvements. I have also modified the templates, so that the next versions will keep this format. Regards Fabio