search

JulienBreux / phpunit-docker

DEPRECATED :package: Docker image to use PHPUnit as CLI.
https://hub.docker.com/r/phpunit/phpunit/
MIT License
47 stars 28 forks source link

composer requires higher version than package name #79

Closed mvhirsch closed 6 years ago

mvhirsch commented 6 years ago

While using composer require is not wrong, the usage of ~ should be avoided in this case. See https://github.com/JulienBreux/phpunit-docker/blob/master/templates/Dockerfile.liquid#L50

Using composer, the image phpunit/phpunit:6.5.3 now uses PHPUnit in version 6.5.5 (because it's allowed within ~).

For example: Docker image 2db97ed81ba6:

$> docker run -it phpunit/phpunit:6.5.3 --help
PHPUnit 6.5.5 by Sebastian Bergmann, Julien Breux (Docker) and contributors.

Instead of using tilde, we should use ^ which will pin it on 6.5.3.* instead of 6.5.3 or higher (on patch-level).

mvhirsch commented 6 years ago

Since this was already fixed, I'll close this issue. Thanks!