search

JulienGrv / saga-revised

Saga Revised is a server emulator for Ragnarok Online 2: The Gate of the World
Other
26 stars 18 forks source link

Only first skill loaded from DB #10

Closed loentar closed 7 years ago

loentar commented 7 years ago

Upon character load only first skill loaded from DB, because of there are unexpected return true statement. It should be outside of while cycle.

This leads to only first skill is loaded and Novice's "Short sword mastery" is not available, because it is the second character's skill.

https://github.com/JulienGrv/saga-revised/blob/0a275bdcff56b80606728e5fcdeadc94a1c4bf26/Abstraction/Saga.Map.Data.Mysql/MysqlProvider.Characters.cs#L1153

JulienGrv commented 7 years ago

Hi loentar! Thank you for your PR, I will review it on Sunday. I am still on holiday until there :)

JulienGrv commented 7 years ago

Fixed with PR #11