search

JulienMaille / dribbblish-dynamic-theme

A mod of Dribbblish theme for Spicetify with support for light/dark modes and album art based colors.
MIT License
332 stars 18 forks source link

Dynamic Colours do not match the album covers at all #110

Closed Fuzqi closed 2 years ago

Fuzqi commented 2 years ago

Describe the bug The dynamic colours that change with the song cover do not match the song cover at all. For example, Whole Lotta Red by Playboi Carti has a red theme to it however my spotify changes to blue whenever it plays that album and there is so aspect of blue in the cover,

To Reproduce Steps to reproduce the behavior: Not really sure, just loaded up spotify and it was bugged,

Screenshots One) https://i.imgur.com/62fRyPp.png One) Clearly no red in the cover yet it's red? Two) https://i.imgur.com/4W5ME72.png Two) There is some orange but it's mainly blue.

Desktop Setup OS: Windows v10.0.22000 Spotify: v1.1.71.560 Spicetify: v2.8.1 Dribbblish: v3.1.1-6f7096b

Logs Add logs from console. To do that

  1. Run spicetify enable-devtool in terminal
  2. Spotify will be restarted
  3. Hit Ctrl + Shift + I to open DevTools window
  4. Navigate to tab Console
  5. Copy console window content.
https://i.imgur.com/i9glcRq.png
Davoleo commented 2 years ago

I think the colors are there, just in a really small region of the cover, I have noticed this behaviour on low saturated album covers as well

SendNukez commented 2 years ago

This is because we're using node-vibrant (basically just an improved version of vibrant.js) which, as the name implies, extracts the vibrant colors from an image. Hence the bright colors. We might switch over to colorthief to get dominant colors, but if we're to use that it would have to be in combination with overhauling the whole color-picking system (#53).