search

JulienMaille / dribbblish-dynamic-theme

A mod of Dribbblish theme for Spicetify with support for light/dark modes and album art based colors.
MIT License
335 stars 17 forks source link

Fix Genres string being bigger than album/artist #221

Closed Davoleo closed 2 years ago

Davoleo commented 2 years ago

That CSS selector was introduced to fix #171 The same issue occurs if you enable the Genres string under the album, this Pull request aims to fix that I'm using a different class selector that seems be used in both the string and nowhere else: image

Screenshots before and after applying the patch: image image

I know, pretty bad timing as you've just published a new release, but it's nothing too major, so it can be postponed until the next release

Davoleo commented 2 years ago

no ok, apparently this fixed itself after updating to the latest version (...?) sorry for the useless PR

Edit: ok yeah it was fixed here: https://github.com/JulienMaille/dribbblish-dynamic-theme/commit/d7e355bf4652f4b4907d47e4f09f5812dea96d6e I somehow completely missed that