search

JulienMaille / spicetify-dynamic-theme

A theme for Spicetify with support for light/dark modes and album art based colors.
MIT License
265 stars 27 forks source link

Automatic system theme application no longer working #38

Closed csforbes closed 11 months ago

csforbes commented 1 year ago

Describe the bug When Spotify desktop is opened with this theme applied, it loads with the Dark theme no matter what the system theme is or what theme was previously set in-app. It does notify "dark theme applied" on first load. When, before, the theme would automatically change in reaction to the system theme, it no longer does.

This started happening after 3 major updates:

  1. Spotify updater forced me to redownload the whole app from browser.
  2. I ran spicetify upgrade to v2.14
  3. I re-ran the MacOS install sh script from the spicetify-dynamic-theme readme.

This is by far my favorite Spicetify theme because of the subtle styling and a good light theme 😱, so thank you for the work you've done on this! Sorry if this is an OS, Spicetify, or personal setup issue I'm misinterpreting.

To Reproduce Steps to reproduce the behavior:

  1. With Spotify quit, Switch MacOS to system light theme.
  2. Open Spotify. (Would show Dark theme still)
  3. Switch Spotify theme manually to light.
  4. Switch MacOS to dark theme. (Spotify would be light still)

Screenshots Spicetify-dynamic-theme-auto-system-bug

Desktop Setup

Logs

cosmos-connector:  fetchAdForSlot endpoint=%o sp://ads/v1/ads/hpto
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/vendor~xpui.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/xpui.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/8696.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/home-hpto.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/4453.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/7269.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/home-v2.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/xpui-desktop-modals.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/5392.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/8419.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
JulienMaille commented 1 year ago

This feature stopped working months ago due to Spotify. A workaround is available under Windows. It relies on patching the .exe file with https://github.com/JulienMaille/spicetify-dynamic-theme/blob/main/patch-dark-mode.ps1 I have no idea if the same can be done under MacOs, can you try?

csforbes commented 1 year ago

Thank you. It was weird that it had been working well right until all the updates. I doubt the exact workaround would work on MacOS, but if I get a chance I’ll dig into it.

On Oct 6, 2022, at 11:51 AM, Julien @.***> wrote:

This feature stopped working months ago due to Spotify. A workaround is available under window relying on patching the .exe file with https://github.com/JulienMaille/spicetify-dynamic-theme/blob/main/patch-dark-mode.ps1 https://github.com/JulienMaille/spicetify-dynamic-theme/blob/main/patch-dark-mode.ps1 I have no idea if the same can be done under MacOs, can you try?

— Reply to this email directly, view it on GitHub https://github.com/JulienMaille/spicetify-dynamic-theme/issues/38#issuecomment-1270403166, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEYOKTMV6FSW2DH2TJGE77TWB37QZANCNFSM6AAAAAAQ6ZBKLY. You are receiving this because you authored the thread.

swrobel commented 1 year ago

I have no idea if the same can be done under MacOs, can you try?

I just tried removing force-dark-mode from the macOS binary using a hex editor, and the app won't launch anymore. I notice that you are replacing it with some character ([byte]65) - can you explain your strategy a bit and maybe I can get it working on a Mac?

legolasdimir commented 1 year ago

a [point with the patch. If you get an update on windows you have to run the patch again.

github-actions[bot] commented 11 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

JulienMaille commented 11 months ago

FIXed thanks to Spotify

gdude2002 commented 10 months ago

This does not appear to be working - Spotify opens with the dark theme set for me, and I always have to toggle it back to light mode manually.

EDIT: The patch that Julien provided here is working for me. Thanks!