search

JulienMaille / spicetify-dynamic-theme

A theme for Spicetify with support for light/dark modes and album art based colors.
MIT License
265 stars 27 forks source link

Theme is not animated #75

Closed Yoruiopz closed 1 week ago

Yoruiopz commented 1 month ago

Describe the bug Background is not animated as shown in the preview.

To Reproduce Steps to reproduce the behavior:

  1. Use the theme and play a song.

Screenshots

Desktop Setup

JulienMaille commented 1 month ago

Please see #74 it might be the similar issue.

Yoruiopz commented 1 month ago

Please see #74 it might be the similar issue.

This is a different issue. The BG is animated in your preview, in my client its a static image with blur on it.

JulienMaille commented 1 month ago

please paste the errors you see in the Console (as explained in the bug report template)

Yoruiopz commented 1 month ago

please paste the errors you see in the Console (as explained in the bug report template)

index.html:1 document.domain mutation is ignored because the surrounding agent cluster is origin-keyed.
4151.css:1 
 Failed to load resource: net::ERR_NAME_NOT_RESOLVED
favicon.ico:1 
 Failed to load resource: net::ERR_NAME_NOT_RESOLVED
extension.js:8 Initializing Spicetify Marketplace v1.0.1
extension.js:8 Loaded Marketplace extension
vendor~xpui.js:1 Uncaught (in promise) Error: enqueueSnackbar called with invalid argument
    at Object.enqueueSnackbar (vendor~xpui.js:1:1704751)
    at Spicetify.showNotification (spicetifyWrapper.js:741:24)
    at e (extension.js:10:774)
xpui.js:1 cosmos-connector:  fetchAdForSlot endpoint=%o sp://ads/v1/ads/hpto
cdn.jsdelivr.net/gh/…ime=1716043886320:1 
 Failed to load resource: the server responded with a status of 403 ()
index.html:1 Refused to execute script from 'https://cdn.jsdelivr.net/gh/surfbryce/beautiful-lyrics@main/dist/beautiful-lyrics.js?time=1716043886320' because its MIME type ('text/plain') is not executable, and strict MIME type checking is enabled.
gew1-spclient.spotif…/v3/configuration:1 
 Failed to load resource: the server responded with a status of 404 ()
vendor~xpui.js:1 provider:transport resolve error 
k

Object
index.html:1 Uncaught (in promise) 
k

JulienMaille commented 1 month ago

Have you tried reinstalled like other did in #74 ? Which theme have you selected in the Marketplace menu? image

Yoruiopz commented 1 month ago

Have you tried reinstalled like other did in #74 ? Which theme have you selected in the Marketplace menu? image

Yes, i tried following the steps to resolve the issue the person in that thread was facing, it did nothing.

I have the "Base" selected on that dropdown menu

JulienMaille commented 1 month ago

Do you have anything else installed from the Marketplace?

ohitstom commented 1 month ago

Do you have anything else installed from the Marketplace?

hi, same issue here, looks totally off from the preview: image

Spotify (release) for Windows (64 bit) 1.2.37.701.ge66eb7bc Spicetify v2.36.11 xpui_2024-05-03_1714757530304_e66eb7b cef_122.1.13+gde5b724+chromium-122.0.6261.130 Runtime: Chrome Build System: CMake

.main-entityHeader-background.main-entityHeader-overlay:after doesnt seem to evaluate nor other classes in the css, looks like a semi rewrite of some stuff will be needed for this latest spotify version

JulienMaille commented 1 month ago

This class still exists on artists pages. I have the exact same version as you do and can't reproduce the issue ... image

Yoruiopz commented 1 month ago

Do you have anything else installed from the Marketplace?

Yes, beautiful Lyrics & Eternal Jukebox.

The image is fetched successfully and blurred, however the image is completely static, i can clearly observe that it's static through seeing the color clamping.

ohitstom commented 1 month ago

this issue is no longer present for me, it seemed like some sort of playerapi issue 👍🏻

Yoruiopz commented 1 month ago

this issue is no longer present for me, it seemed like some sort of playerapi issue 👍🏻

how did you fix it?

ohitstom commented 1 month ago

this issue is no longer present for me, it seemed like some sort of playerapi issue 👍🏻

how did you fix it?

i reinstalled spotify which made my player state empty then when i played a song everything started working - thats all i know though

Yoruiopz commented 4 weeks ago

@JulienMaille Let us know if you find a solution, it is still persisting for me even after 3+ updates to spicetify

JulienMaille commented 3 weeks ago

vendor\~xpui.js:1 Uncaught (in promise) Error: enqueueSnackbar called with invalid argument at Object.enqueueSnackbar (vendor\~xpui.js:1:1704751) at Spicetify.showNotification (spicetifyWrapper.js:741:24) at e (extension.js:10:774)

I think you have something wrong with your setup @Yoruiopz

Yoruiopz commented 1 week ago

vendor\~xpui.js:1 Uncaught (in promise) Error: enqueueSnackbar called with invalid argument at Object.enqueueSnackbar (vendor\~xpui.js:1:1704751) at Spicetify.showNotification (spicetifyWrapper.js:741:24) at e (extension.js:10:774)

I think you have something wrong with your setup @Yoruiopz

The enqueueSnackbar error indicates that an invalid argument is being passed to the function, suggesting an issue within the code implementation rather than my setup.

It seems the arguments passed to enqueueSnackbar are either missing, malformed, or of incorrect types. I've tried reinstalling Spotify and Spicetify and ensuring the "Base" theme is selected from the Marketplace menu, but the issue persists.

JulienMaille commented 1 week ago

Where is the call to enqueueSnackbar located? It's not in this theme. Have you tried removing beautiful Lyrics and Eternal Jukebox to see if it helps?

EDIT: I believe this comes from the Marketplace image

Yoruiopz commented 1 week ago

Where is the call to enqueueSnackbar located? It's not in this theme. Have you tried removing beautiful Lyrics and Eternal Jukebox to see if it helps?

EDIT: I believe this comes from the Marketplace image

I tried removing Beautiful Lyrics and Eternal Jukebox, but the issue persists.

JulienMaille commented 1 week ago

Have you tried to update/reinstall the marketplace?

Yoruiopz commented 1 week ago

Have you tried to update/reinstall the marketplace?

Yes, the issue still persists.

Yoruiopz commented 1 week ago

Additionally, when switching songs, the background doesn't transition smoothly. It abruptly cuts to the blurred and zoomed-in version of the new cover art. Same with switching to light/dark mode.

Yoruiopz commented 1 week ago

After further troubleshooting, I found a solution in the Spicetify Discord. The issue was caused by having "Animation Effects" turned off in my Windows settings under Accessibility. While I believe having this feature on negatively impacts performance and makes Windows appear sluggish, it seems that Windows 11 now overrides the animation properties listed in your CSS when this setting is disabled, which I find quite stupid to be honest considering Spotify is a standalone application.

I discovered this by noticing the lack of animation in other snippets, prompting me to investigate further.

I hope this helps anyone encountering the same issue in the future.