search

JulienMasson / org-gtasks

Org sync with Google Tasks
GNU General Public License v3.0
49 stars 16 forks source link

Add support for links field of Task resource #2

Closed telotortium closed 4 years ago

telotortium commented 4 years ago

See https://developers.google.com/tasks/v1/reference/tasks#resource.

JulienMasson commented 4 years ago

Hi, Sorry for the late reply, thanks for your contribution I appreciate it. Just one minor remark on the code, otherwise it looks good to me :)

JulienMasson commented 4 years ago

Can you please squash these two commits: https://github.com/JulienMasson/org-gtasks/pull/2/commits/f1f36f8b7c6d2e7cc4067b69b6303e34756a9458 https://github.com/JulienMasson/org-gtasks/pull/2/commits/5c630c438dd1be824bac5510dcb0b5deac064fb4

telotortium commented 4 years ago

Done

On Fri, Oct 4, 2019 at 1:30 AM Julien Masson notifications@github.com wrote:

Can you please squash these two commits: f1f36f8 https://github.com/JulienMasson/org-gtasks/commit/f1f36f8b7c6d2e7cc4067b69b6303e34756a9458 5c630c4 https://github.com/JulienMasson/org-gtasks/commit/5c630c438dd1be824bac5510dcb0b5deac064fb4

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JulienMasson/org-gtasks/pull/2?email_source=notifications&email_token=AANMVDJOMRGWR3YCJLV4HY3QM35L5A5CNFSM4I3ATZD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAK5O2Y#issuecomment-538302315, or mute the thread https://github.com/notifications/unsubscribe-auth/AANMVDJ3ZK6BOQJQYH74633QM35L5ANCNFSM4I3ATZDQ .

-- Robert Irelan rirelan@gmail.com

telotortium commented 4 years ago

Done

On Mon, Oct 7, 2019 at 6:41 AM Julien Masson notifications@github.com wrote:

@JulienMasson commented on this pull request.

In org-gtasks.el https://github.com/JulienMasson/org-gtasks/pull/2#discussion_r332024266:

@@ -339,7 +339,7 @@ (notes (replace-regexp-in-string org-gtasks-links-drawer-re "" notes)) ;; Strip leading and trailing newlines in notes

  • (notes (replace-regexp-in-string "\`\n+" "" notes))
  • (notes (string-trim notes)) (notes (replace-regexp-in-string "\n+\'" "" notes))

Thanks for the squash but you still have in your commit: (notes (replace-regexp-in-string "\n+\'" "" notes)) Please remove this line, amend this patch and that will be perfect :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JulienMasson/org-gtasks/pull/2?email_source=notifications&email_token=AANMVDOPVTK36J6Y4TAEVY3QNM4CDA5CNFSM4I3ATZD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHCS5AQ#discussion_r332024266, or mute the thread https://github.com/notifications/unsubscribe-auth/AANMVDKIZARF7H4DKKCBAXTQNM4CDANCNFSM4I3ATZDQ .

-- Robert Irelan rirelan@gmail.com

JulienMasson commented 4 years ago

Thanks @telotortium :)