search

JulienPalard / multihash

Python 3, PEP 247 compliant, multihash implementation.
5 stars 3 forks source link

Python 2 compliance? #2

Open mvanveen opened 9 years ago

mvanveen commented 9 years ago

Hi,

I spent my night working on hacking in your library into py-ipfs. I noticed this issue thread and set out to include it under the auspice that py-ipfs was supporting both 2 and 3.

Much to my chagrin, I subsequently observed that there's another thread open where 2/3 compliance is up in the air.

I notice your stated opinion is to focus on 3-only compliance, but I'm wondering if you'd be open to accepting changes for 2 compliance? I understand it will probably make the source code a bit kludgier (e.g. I might use a 3rd party lib from pip instead of a python3 stdlib module), but I think it might increase the utilization and overall usability of this library.

I've got a branch open with some changes already, let me know and I'll close it out and send you a PR!

Cheers,

--mff

JulienPalard commented 9 years ago

For the record, let's keep your proposal in a branch. We don't know, for now, if py-IPFS will be Python 2.7 compatible, so don't erase your code.

Also I personally never wrote Python 3 code being Python 2.7 compatible, so I'm interested to see how my code is modified to do so :-)