search

Julienh / Sharrre

Make your sharing widget! Sharrre is a jQuery plugin that allows you to create nice widgets sharing for Facebook, Twitter, Google Plus (with PHP script) and more.
sharrre.com
MIT License
1.04k stars 413 forks source link

Fix Facebook Count #296

Open njt1982 opened 7 years ago

njt1982 commented 7 years ago

Applying fix from #294 by @sphism

sphism commented 7 years ago

Cheers mate

aandrewjoyce commented 7 years ago

Still showing up issues on my end after replacing the minified file in production.

njt1982 commented 7 years ago

@aandrewjoyce any errors in console? What happens in the network tab? What's the production URL?

(It's a little hard to debug/help without any more info).

sphism commented 7 years ago

@aandrewjoyce have you managed to get any share counts using the graph api explorer?

https://developers.facebook.com/tools/explorer/145634995501895/?method=GET&path=%3Fid%3Dhttp%253A%252F%252Fwww.imdb.com%252Ftitle%252Ftt2015381%252F&version=v2.7

AlainVagner commented 7 years ago

on my side, the call was done correctly to facebook, but the info was not displayed. I have found that on some browsers, testing that the resulting json.share object was not empty using json.share.length > 0 was not working. Please see this change https://github.com/AlainVagner/Sharrre/commit/59528271500bd8e7ddf1aff20bc5799a65c7d00a