Julienh / Sharrre

Make your sharing widget! Sharrre is a jQuery plugin that allows you to create nice widgets sharing for Facebook, Twitter, Google Plus (with PHP script) and more.
sharrre.com
MIT License
1.04k stars 411 forks source link

Facebook popup doesn't close after sharing #98

Open MadeByKarl opened 11 years ago

MadeByKarl commented 11 years ago

Hi!

In the examples as in the project I'm currently working on, when I share on Facebook, the popup doesn't close after the page is shared. Instead, the popup window reloads and a new share form appears without anything to share. Capture d e cran 2012-12-15 a 00 34 38 Capture d e cran 2012-12-15 a 00 35 05

Any solution?

Cheers!

arnaudbreton commented 11 years ago

It seems that the sharer url is deprecated.

It has been replaced by the feed dialog : https://developers.facebook.com/docs/reference/dialogs/feed/

I'll try to integrate it

[EDIT] Ok, I managed to integrate the feed dialog. Fortunately the code is clear and very easy to modify (congrats Julien!).

At line 322, I replaced the call to window.open(sharer.php...) by this :

if(FB && FB.ui) { var obj = { method: 'send', link: opt.buttons.facebook.url !== '' ? opt.buttons.facebook.url : opt.url }; FB.ui(obj); }

In fact, the Feed dialog doesn't fit our needs. For example, you can't share to a specific friend like the sharer. You have to use the send dialog for that : https://developers.facebook.com/docs/reference/dialogs/send/

Unfortunately, the sharer.php doesn't seems to provide a "redirect_uri" params. It would let us redirect to a custom page which only do a window.close().

For the moment, we'll use Sharrer to render the official social buttons.

yuanzhou commented 11 years ago

I found the same issue. However, there is now mention of it here

developers.facebook.com/docs/reference/plugins/like

under 'What happened to the old Share button?'

What happened to the old Share button?

We deprecated the Share Button when we launched the Like button, because the Like button improves clickthrough rates by allowing users to connect with one click, and by allowing them to see which of their friends have already connected. For reference, the Share button documentation is still available here.

If you decide to switch to the Feed Dialog, you will need to specify the redirect_url and this may help you: http://stackoverflow.com/questions/8497217/fb-ui-popup-window-doesnt-close

MadeByKarl commented 11 years ago

Ok, thanks for your help and support!