JulietTeoh / pe

0 stars 0 forks source link

Sorting does not persist when adding a new property #10

Open JulietTeoh opened 3 years ago

JulietTeoh commented 3 years ago

First, I sorted the properties by price and I expect the new property I add to be added to index 1 of the list, due to its highest price.

However, it is added to the bottom of the list instead.

Screenshot 2021-04-16 at 3.04.46 PM.png

Screenshot 2021-04-16 at 3.09.14 PM.png

nus-pe-bot commented 3 years ago

Team's Response

The sorting feature is designed to only sort the currently displayed list. Add commands are designed to always add the new property or appointment at the end of the property or appointment list so it is easier for users to find the newly added property or appointment. Thus, the sorting effect should not affect the later add commands.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Firstly, looking at your user guide, you did not mention that sorting does not persist and that "the sorting effect should not affect the later add commands". Thus, most users will just assume that sorting will persist, because that is the common behaviour in many apps and programs that they use.

For instance, when using the pandas dataframe and I sort a dataframe of grocery items by price in descending order, when I add a new grocery item that is expensive, I do not expect it to appear on the bottom of the list. In fact, I expect it to appear in its correct place with the rest of the existing items in the dataframe. In another example, if I sort my stocks watchlist by alphabetical order and I add a new stock starting with letter "A" into my watchlist, I expect it to be near the top of the list, and not the bottom.

Thus, it can be very confusing to users. For instance, when a user sorts their properties by price in descending order, and then they add a new property with the highest price out of all the properties, they would expect that the new property appears on the top of the list because it has the highest price. However, in the current program, not matter what previous ordering has been specified, the newly added items will be added to the bottom of the list. This is a bug in your program, as users have to keep resorting their properties as long as they add in new properties. Thus, the bug report still holds.

This bug should be of severity.Medium because of the reasons stated above.