nus-pe-bot
commented
3 years ago Team's Response
No response provided.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
For entering invalid index for update, different error messages given
When the index is less than 0, one error message and with index = 0 or more than elements in list, error message highlighting index is shown.
[original: nus-cs2103-AY2021S2/pe-interim#2932] [original labels: severity.Medium type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
There was a discussion regarding how negative values should be handled. While trying to fix a bug found during PE dry-run, we decided to show an invalid command error for negative values as we believed that the average user would not perceive the "-" in front of the INDEX as a negative INDEX but as an invalid command. As a result, more code was added to ensure that "-" in front of the INDEX would show the invalid command error. Furthermore, the UG mentioned that only positive integers should be used.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: In your manual instructions for testing, you stated that delete property 0, delete, delete property x (where x is larger than the list size) should have similar error messages.
However, delete 0, delete 100 and delete 1000000000000 have different error messages.
This inconsistency can be confusing to the users of the program, and thus this inconsistent error message is still a bug.
:question: Issue response
Team chose [response.Rejected]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
delete property 0, delete property -10, delete property 10, delete property 1000000000000000000000000 should provide the same error messages
However, they do not, which can be misleading to users. Furthermore, you wrote in the manual testing guide in the DG that delete property x (where x is larger than the list size) should show the same error message as delete property 0, but that is not the case.