JulietTeoh / pe

0 stars 0 forks source link

No link between the appointments and property #8

Open JulietTeoh opened 3 years ago

JulietTeoh commented 3 years ago

add property n/Pasir Ris t/Hdb a/testing p/000000 d/30-06-2021 cn/Lulu add appointment n/Meet Lulu r/For collection of commission d/19-05-2021 t/1930 find client Lulu delete appointment 1

When a appointment with a client is delete, the property under that client is not affected in any way. This can confuse the user as he might wonder who this old obselete client is/was, and it would be better if the client details under the property was deleted as well.

Screenshot 2021-04-16 at 2.57.33 PM.png

Commands to input: Screenshot 2021-04-16 at 2.58.16 PM.png

nus-pe-bot commented 3 years ago

Team's Response

Deleting an appointment with a client will not delete a property with the same client name as client name may not be unique. It will not be appropriate to delete all properties with the same client name as this can result in unexpected data loss.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Looking at the bigger picture, Properties and Clients should be linked through an association class named Appointments. (e.g. Man, Woman and Marriage)

In your implementation, the client class is not found, as property and appointments could have the same client name but they are not linked as deleting a property under a client's name does not affect any of the appointments at all.

Thus, it seems to suggest that your app is not very cohesive, which is a valid feature flaw.