search

Julius2342 / pyvlx

PyVLX - controling VELUX windows with Python via KLF 200
GNU Lesser General Public License v3.0
74 stars 26 forks source link

Adds typing support #338

Closed palfrey closed 9 months ago

palfrey commented 11 months ago
codecov-commenter commented 11 months ago

Codecov Report

Merging #338 (db4df4f) into master (2649f1c) will increase coverage by 0.27%. The diff coverage is 95.03%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   81.69%   81.96%   +0.27%     
==========================================
  Files          77       77              
  Lines        3272     3388     +116     
==========================================
+ Hits         2673     2777     +104     
- Misses        599      611      +12
Files Coverage Δ
pyvlx/api/factory_default.py 47.05% <100.00%> (+3.30%) :arrow_up:
pyvlx/api/frame_creation.py 97.74% <100.00%> (+0.01%) :arrow_up:
pyvlx/api/frames/alias_array.py 100.00% <100.00%> (ø)
pyvlx/api/frames/frame.py 100.00% <100.00%> (ø)
pyvlx/api/frames/frame_activate_scene.py 100.00% <100.00%> (ø)
pyvlx/api/frames/frame_activation_log_updated.py 100.00% <100.00%> (ø)
pyvlx/api/frames/frame_command_send.py 100.00% <100.00%> (ø)
pyvlx/api/frames/frame_discover_nodes.py 100.00% <100.00%> (ø)
pyvlx/api/frames/frame_error_notification.py 100.00% <100.00%> (ø)
pyvlx/api/frames/frame_facory_default.py 100.00% <100.00%> (ø)
... and 62 more
palfrey commented 9 months ago

Any thoughts @Julius2342?

Julius2342 commented 9 months ago

@palfrey : my apologies! Have overseen this PR! Will review tomorrow! sorry for the long wait!