search

Julius2342 / pyvlx

PyVLX - controling VELUX windows with Python via KLF 200
GNU Lesser General Public License v3.0
74 stars 26 forks source link

Merge_try #350

Closed pawlizio closed 8 months ago

pawlizio commented 9 months ago
pawlizio commented 9 months ago

@Julius2342 : I think it is ready from my side. If you dont mind, we can merge this now.

Once it is merged, I can redirect my custom back to this fork/branch, at least once a new release is created. Finally we can then work improving the HA velux integration to include the features which are now only available in my custom. However due to missing experience in coding, especially unittest, for me this would be a long story. Personally I would appreciate to get rid of my custom, it is just easire for me to include new features there instead of learning all that python staff.

Julius2342 commented 9 months ago

3.9 is still failing, should we ditch 3.9 support :)

pawlizio commented 9 months ago

3.9 is still failing, should we ditch 3.9 support :)

Either that or I need to modify the "|" type hints to support Python 3.9: velocity: Velocity | int | None = Velocity.DEFAULT,

into something like that: velocity: Union[Velocity, int, None] = Velocity.DEFAULT,

Which way you prefer?

Julius2342 commented 9 months ago

3.9 is still failing, should we ditch 3.9 support :)

Either that or I need to modify the "|" type hints to support Python 3.9: velocity: Velocity | int | None = Velocity.DEFAULT,

into something like that: velocity: Union[Velocity, int, None] = Velocity.DEFAULT,

Which way you prefer?

I think 99% of the use cases of this library are home-assistant. So it is fine to keep the minumum supported version aligned with them.

And if we are aligned, we should pick the most-modern python possible.

So lets drop 3.9 ...

codecov-commenter commented 8 months ago

Codecov Report

Attention: 213 lines in your changes are missing coverage. Please review.

Comparison is base (8abf076) 81.96% compared to head (b7089ec) 79.97%. Report is 1 commits behind head on master.

Files Patch % Lines
pyvlx/opening_device.py 34.71% 79 Missing :warning:
pyvlx/node_updater.py 10.76% 58 Missing :warning:
pyvlx/heartbeat.py 33.33% 24 Missing :warning:
pyvlx/klf200gateway.py 20.00% 12 Missing :warning:
pyvlx/parameter.py 78.57% 12 Missing :warning:
pyvlx/connection.py 25.00% 9 Missing :warning:
pyvlx/pyvlx.py 38.46% 8 Missing :warning:
pyvlx/const.py 71.42% 4 Missing :warning:
pyvlx/lightening_device.py 60.00% 2 Missing :warning:
pyvlx/on_off_switch.py 50.00% 2 Missing :warning:
... and 3 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #350 +/- ## ========================================== - Coverage 81.96% 79.97% -1.99% ========================================== Files 77 77 Lines 3387 3560 +173 ========================================== + Hits 2776 2847 +71 - Misses 611 713 +102 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Julius2342 commented 8 months ago

@pawlizio : good morning :) Are we ready to merge this PR? What do you think?

Julius2342 commented 8 months ago

Yes, i will bump a version after merge. May I ask you to provide a bulletpoint list of major changes of this PR for the changelog?

Julius2342 commented 8 months ago

Yay!

pawlizio commented 8 months ago

I added a list above.

Julius2342 commented 8 months ago

I released 0.2.21 and uploaded to pypi ...