search

Julius2342 / pyvlx

PyVLX - controling VELUX windows with Python via KLF 200
GNU Lesser General Public License v3.0
74 stars 26 forks source link

Fix blind orientation on first call #362

Closed pawlizio closed 8 months ago

pawlizio commented 8 months ago

We should initiate with TargetPosition, otherwise Blind orientation can not be changed until position has been changed on HA start.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d1fee9e) 79.97% compared to head (7b81cdb) 80.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #362 +/- ## ========================================== + Coverage 79.97% 80.00% +0.02% ========================================== Files 77 77 Lines 3560 3560 ========================================== + Hits 2847 2848 +1 + Misses 713 712 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pawlizio commented 8 months ago

Something is going wrong with github. It still shows me, that I'm 184 commits ahead...

image
Julius2342 commented 8 months ago

Something is going wrong with github. It still shows me, that I'm 184 commits ahead...

Probably bc the large MR from you was squashed when merging. This creates one large commit - and therefore conflicts with your original clone.