search

Julius2342 / pyvlx

PyVLX - controling VELUX windows with Python via KLF 200
GNU Lesser General Public License v3.0
73 stars 26 forks source link

Availability-updates #371

Closed pawlizio closed 5 months ago

pawlizio commented 6 months ago

Add support for check connectivity updates. Required for https://github.com/pawlizio/my_velux/pull/38

codecov-commenter commented 6 months ago

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (4ae18e3) 80.00% compared to head (731f0b2) 79.64%.

Files Patch % Lines
pyvlx/pyvlx.py 31.25% 11 Missing :warning:
pyvlx/api/api_event.py 0.00% 10 Missing :warning:
pyvlx/connection.py 57.89% 8 Missing :warning:
pyvlx/klf200gateway.py 0.00% 1 Missing :warning:
pyvlx/node.py 66.66% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #371 +/- ## ========================================== - Coverage 80.00% 79.64% -0.36% ========================================== Files 77 77 Lines 3560 3596 +36 ========================================== + Hits 2848 2864 +16 - Misses 712 732 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pawlizio commented 6 months ago

@dumpfheimer : I hope you don't mind, as I've closed your PR in my pyvlx and therefore now cherry picked your commits to create this PR in order to avoid that your work goes lost.

dumpfheimer commented 6 months ago

@dumpfheimer : I hope you don't mind, as I've closed your PR in my pyvlx and therefore now cherry picked your commits to create this PR in order to avoid that your work goes lost.

Not at all! Thanks for taking the time!