Julusian / node-elgato-stream-deck

A Node.js library for interfacing with the Elgato Stream Deck. https://julusian.github.io/node-elgato-stream-deck/
https://www.npmjs.com/org/elgato-stream-deck
MIT License
159 stars 22 forks source link

Incompatible with Electron 21 due to V8 Memory Cage? #57

Closed matthewdwatkins closed 1 year ago

matthewdwatkins commented 1 year ago

Hello! I am getting this error when using this module in Electron 21:

[22072:0928/013445.372:ERROR:node_bindings.cc(146)] Fatal error in V8: v8_ArrayBuffer_NewBackingStore When the V8 Sandbox is enabled, ArrayBuffer backing stores must be allocated inside the sandbox address space. Please use an appropriate ArrayBuffer::Allocator to allocate these buffers.

I believe it has to do with this change in Electron's code:

https://www.electronjs.org/blog/v8-memory-cage

Julusian commented 1 year ago

Yep, this is a known issue with both node-hid and @julusian/jpeg-turbo

For now, stick with Electron 20. Ill fix these issues when I can, but if you use any other modules (eg sharp) then you might also be waiting for them to be updated too

matthewdwatkins commented 1 year ago

Great, thank you!

Julusian commented 1 year ago

Both node-hid and @julusian/jpeg-turbo now have electron 21 compatible versions