search

Julusian / node-elgato-stream-deck

A Node.js library for interfacing with the Elgato Stream Deck. https://julusian.github.io/node-elgato-stream-deck/
https://www.npmjs.com/org/elgato-stream-deck
MIT License
163 stars 21 forks source link

feat!: rework properties describing functionality and refactor internals #97

Closed Julusian closed 3 months ago

Julusian commented 4 months ago

This performs some large refactoring/reworking of the library that will form the basis of a v7.0 release.

The aim of this is to make non lcd-button controls feel more native, rather than the afterthought that they are. These have all been tacked on in response to new hardware being released.

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 56.34146% with 358 lines in your changes missing coverage. Please review.

Project coverage is 54.66%. Comparing base (e0ac909) to head (14a3355). Report is 1 commits behind head on main.

Files Patch % Lines
...ges/core/src/services/buttonsLcdDisplay/default.ts 58.64% 54 Missing and 1 partial :warning:
packages/core/src/services/lcdStripDisplay/plus.ts 8.69% 38 Missing and 4 partials :warning:
packages/core/src/services/input/gen2.ts 35.93% 38 Missing and 3 partials :warning:
...s/core/src/services/imageWriter/headerGenerator.ts 29.78% 33 Missing :warning:
packages/core/src/services/lcdStripDisplay/neo.ts 10.81% 30 Missing and 3 partials :warning:
packages/core/src/proxy.ts 0.00% 32 Missing :warning:
packages/webhid/src/index.ts 0.00% 26 Missing :warning:
packages/core/src/models/base.ts 69.81% 12 Missing and 4 partials :warning:
packages/webhid/src/wrapper.ts 0.00% 10 Missing and 4 partials :warning:
packages/core/src/services/properties/pedal.ts 7.69% 12 Missing :warning:
... and 12 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #97 +/- ## ========================================== + Coverage 53.41% 54.66% +1.24% ========================================== Files 28 38 +10 Lines 863 1030 +167 Branches 91 125 +34 ========================================== + Hits 461 563 +102 - Misses 402 444 +42 - Partials 0 23 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.