Julusian / node-midi

A node.js wrapper for RtMidi providing MIDI I/O
https://www.npmjs.com/package/@julusian/midi
MIT License
22 stars 7 forks source link

chore(master): release 3.5.0 #27

Closed Julusian closed 1 month ago

Julusian commented 1 month ago

:robot: I have created a release beep boop

3.5.0 (2024-07-14)

Features


This PR was generated with Release Please. See documentation.

Julusian commented 1 month ago

:robot: Release is at https://github.com/Julusian/node-midi/releases/tag/v3.5.0 :sunflower:

BogdanDenis commented 1 month ago

Hey @Julusian, the new constants don't seem to be included in the npm package which causes these errors:

ERROR in ./node_modules/@julusian/midi/midi.js 12:20-44
Module not found: Error: Can't resolve './instruments' in 'C:\Users\dbohdan\Documents\programming\midiJoy\node_modules\@julusian\midi'
 @ ./src/controllers/midi/midi.js 4:13-38
 @ ./src/main.js

ERROR in ./node_modules/@julusian/midi/midi.js 14:14-32
Module not found: Error: Can't resolve './drums' in 'C:\Users\dbohdan\Documents\programming\midiJoy\node_modules\@julusian\midi'
 @ ./src/controllers/midi/midi.js 4:13-38
 @ ./src/main.js

ERROR in ./node_modules/@julusian/midi/midi.js 16:14-32
Module not found: Error: Can't resolve './notes' in 'C:\Users\dbohdan\Documents\programming\midiJoy\node_modules\@julusian\midi'
 @ ./src/controllers/midi/midi.js 4:13-38
 @ ./src/main.js

ERROR in ./node_modules/@julusian/midi/midi.js 18:17-38
Module not found: Error: Can't resolve './messages' in 'C:\Users\dbohdan\Documents\programming\midiJoy\node_modules\@julusian\midi'
 @ ./src/controllers/midi/midi.js 4:13-38
 @ ./src/main.js

I can use 3.4.0 for now, just wanted to give a heads up. P.S.: Really awesome package - people who create Node wrappers for C/C++ DLLs are the real heroes!

Julusian commented 1 month ago

@BogdanDenis thanks for letting me know, 3.5.3 is building now which should resolve this