search

Julusian / node-midi

A node.js wrapper for RtMidi providing MIDI I/O
https://www.npmjs.com/package/@julusian/midi
MIT License
22 stars 7 forks source link

WIP: Release ports on closePort. #8

Closed halfbyte closed 1 year ago

halfbyte commented 1 year ago

Potential fix for #7

Not sure this is the behaviour we want, but it's a start.

I didn't yet add tests to it, but the manual test "input/input-reopen-test.js" definitely fails.

Julusian commented 1 year ago

Hmm yeah I think that 'test' proves that this would be a breaking change to do it in closePort.

So I agree that a release method would be best.
Sorry about htat

Julusian commented 1 year ago

Replaced with #10