search

JulyIghor / QtBitcoinTrader

Secure multi crypto exchange trading client
https://sourceforge.net/projects/bitcointrader/
736 stars 374 forks source link

Sell and Buy price are mixed up #117

Closed blaer closed 10 years ago

blaer commented 10 years ago

Where it says "Buy price" it displays sell price and vice versa. I'm using btc-e. On ubuntu. Compiled from latest version from Github.

JulyIghor commented 10 years ago

Can you make screenshot with fixed text?

blaer commented 10 years ago

Shure, no problem. I fixed it by switching the names of the labels in the .ui file. But i don't know if that is the best solution. [image: Inline image 2]

On Fri, Jan 10, 2014 at 9:45 PM, IGHOR notifications@github.com wrote:

Can you make screenshot with fixed labels?

— Reply to this email directly or view it on GitHubhttps://github.com/JulyIGHOR/QtBitcoinTrader/issues/117#issuecomment-32064263 .

JulyIghor commented 10 years ago

I don't see image. I just want to know how you think it must looks.

blaer commented 10 years ago

Added the image as attachment now (it was an inline image). :)

In the "Market" section. There is a field that says "Sell". In that field the number for buy is displayed. That is incorrect. The number for sell should be displayed. The same for the field that says "Buy". In that field the number for sell is displayed. Again, that is incorrect. The number for buy should be displayed.

In the screenshot i show the application and the btc-e web interface so you can compare the numbers. screenshot from 2014-01-11 08 38 54a

Cheers! Bart

Squeaker commented 10 years ago

maybe to avoid some confusion (which was a problem in the code as the Market Sell spinbox is named marketBuy, and vice versa... even tho it is logical why they were done that way... but it mixes up action with object and didn't feel at all natural the way I had to keep catching myself.

Perhaps label them "Ask:" and "Bid:", and name the spinboxes "marketAsk" and "marketBid", respectively? then we reserve using 'buy' and 'sell' specifically for the action of buying and selling.

=squeak=

JulyIghor commented 10 years ago

https://bitcointalk.org/index.php?topic=372464.0

JulyIghor commented 10 years ago

Ok, I'll make ask, bid labels. Sorry for my bad English.

Squeaker commented 10 years ago

No problem. :) We all contribute where we can. :D

=squeak=

From: IGHOR notifications@github.com To: JulyIGHOR/QtBitcoinTrader QtBitcoinTrader@noreply.github.com Cc: Squeaker squeaker1024@yahoo.com Sent: Saturday, January 11, 2014 3:05 PM Subject: Re: [QtBitcoinTrader] Sell and Buy price are mixed up (#117)

Ok, I'll make ask, bid labels. Sorry for my bad English. — Reply to this email directly or view it on GitHub.

JulyIghor commented 10 years ago

Done