JulyIghor / QtBitcoinTrader

Secure multi crypto exchange trading client
https://sourceforge.net/projects/bitcointrader/
736 stars 374 forks source link

License update (Closes: #27): #118

Closed onlyjob closed 10 years ago

onlyjob commented 10 years ago
rzhv commented 10 years ago

Please, consider my comment on why choosing LGPL for the entire project might not be a good idea: https://github.com/JulyIGHOR/QtBitcoinTrader/issues/27#issuecomment-32689118

onlyjob commented 10 years ago

@rzhv: In your comment I found no arguments why to prefer other license(s) over LGPL. But please don't bother arguing as perhaps the following link explains what you were trying to say:

https://www.gnu.org/licenses/why-not-lgpl.html

ralyodio commented 10 years ago

why not MIT?

onlyjob commented 10 years ago

IMHO because MIT is not copyleft license. Personally I prefer (L/A)GPL and I think it is better for software. In this particular case the actual text of the license in "LICENSE.GPL3" file is LGPL-3 so I'm just helping to make the application of this license consistent.

rzhv commented 10 years ago

@onlyjob: If you take a good look then you will see that the author used GPL3 everywhere:

Then why are you persisting that the author wanted LGPL? Just because you found it in one file LICENSE.GPL3 (GPL3 again!), which probably was a wrong copy-paste of GPL3?

From the previous comment by the author (https://github.com/JulyIGHOR/QtBitcoinTrader/issues/27#issuecomment-20469461) I can tell that he was quite OK to add the exception lines to his files and keep GPL3.

@onlyjob: "But please don't bother arguing as perhaps the following link explains what you were trying to say" Yes it does explain it too, so why not accept this explanation? The author does not need LGPL to link to OpenSSL in his code. If you really care about making QtBitcoinTrader follow Debian rules, then follow Debian rules! Help the author add an exception to GPL3 as suggested by the Debian guys: https://lists.debian.org/debian-legal/2004/05/msg00595.html.

@JulyIGHOR : If you need help, then I can make a pull request with the changes needed to include the special exception to the GPL3 headers of your files and correct the license text in LICENSE.GPL3. Just let me know...

P.S. However you look at it, changing license is a serious legal action, so I advice the author to not rush things and think twise before making any changes, given that his project has grown quite big already in size and popularity!

onlyjob commented 10 years ago

@rzhv, your speculations are as good as mine. Calm down and wait patiently for author to clarify the license.

JulyIghor commented 10 years ago

Hi. Project is not library. So license is GPL3 What should I change to allow openssl linking? And what to put in LICENSE.GPL3?

Please send to my email correct LICENSE.GPL3 file and text of cpp and h header.

onlyjob commented 10 years ago

@JulyIGHOR: I'll update my pull request for GPL-3+ & OpenSSL exception so everything you'll need to do is to merge it. Stay tuned, I'll get back to you in few days and will let you know when it's ready to merge. :)

onlyjob commented 10 years ago

Ready to merge.

rzhv commented 10 years ago

Good job! Thank you for this commit!