search

JulyIghor / QtBitcoinTrader

Secure multi crypto exchange trading client
https://sourceforge.net/projects/bitcointrader/
730 stars 374 forks source link

password length and usability issue #150

Closed onlyjob closed 10 years ago

onlyjob commented 10 years ago

With 1.07.99 I created new BTC-E profile with 13-characters long password. New password dialog suggests that "password must be at least 8 characters" but "[OK]" button in unlock dialog remains inactive until 15 characters typed into "password" field.

Inactive button is a usability issue because nothing indicates why it is inactive let alone lack of visual feedback -- locked and un-locked "[OK]" button look exactly the same. "[OK]" button responds only when enough characters typed.

15 characters limit is unreasonable and allow to create inaccessible profiles. Besides it is a wrong place to enforce password length in profile unlock dialog. If user wish to have a weak password (s)he must be allowed to do so as profile may be secured by disk or file system encryption etc.

JulyIghor commented 10 years ago

Fixed

onlyjob commented 10 years ago

I tested and found it much better, thank you. I would only like to suggest including bug number with ('#' character) to corresponding commit messages. Cheers.