search

JulyIghor / QtBitcoinTrader

Secure multi crypto exchange trading client
https://sourceforge.net/projects/bitcointrader/
734 stars 376 forks source link

Bitfinex manual buy/sell and rule-buy orders do not execute #154

Closed xbrooks closed 10 years ago

xbrooks commented 10 years ago

Manual buy/sell orders do not run. Rules also fail to create buy orders. Rules do create sell orders.

Sufficient balance: yes Valid rule: yes Tested with Litecoin on Linux and latest Windows version via Wine.

(Thanks for the Linux compile fix in latest version!!)

JulyIghor commented 10 years ago

Thanks for bug report. Can you please press Alt+Shift+D or Ctrl+Shift+D while app is running, than switch to debug mode on bottom. Than try to open order and 20 seconds later save debug output and place it here. It will helps me to fix it faster.

xbrooks commented 10 years ago

2014-08-27 12:06:22 LVL:0

HTTP: connection closed

2014-08-27 12:06:22 LVL:2

Sending request ID: 307

2014-08-27 12:06:22 LVL:0 SND: POST /v1/order/new HTTP/1.1 User-Agent: Qt Bitcoin Trader v1.07.99 Host: api.bitfinex.com Accept-Encoding: gzip Content-Type: application/x-www-form-urlencoded Connection: keep-alive Cookie: THERE_WAS_A_COOKIE X-BFX-APIKEY: REST_KEY X-BFX-PAYLOAD: eyJyZXF1ZXN0IjogIi92MS9vcmRlci9uZXciLCAibm9uY2UiOiAiMzczMDQyOTM0IiwgInN5bWJvbCI6ICJsdGN1c2QiLCAiYW1vdW50IjogIjEuNzAwMDAwMDAiLCAicHJpY2UiOiAiNi4wMDAwMDAwMCIsICJleGNoYW5nZSI6ICJhbGwiLCAic2lkZSI6ICJzZWxsIiwgInR5cGUiOiAibGltaXQifQ== X-BFX-SIGNATURE: b4b062ec043f09eadc01094c878d66ff3a2a79328d251d6670b9bd3bdc716be9065586af631c85be3b8945ed3e5b5247 Content-Length: 169

{"request": "/v1/order/new", "nonce": "373042934", "symbol": "ltcusd", "amount": "1.70000000", "price": "6.00000000", "exchange": "all", "side": "sell", "type": "limit"}

2014-08-27 12:06:23 LVL:0 HTTP/1.1 400 Bad Request Date: Wed, 27 Aug 2014 17:06:25 GMT Server: Apache/2.2.15 (CentOS) Vary: Accept-Encoding Content-Encoding: gzip X-UA-Compatible: IE=Edge,chrome=1 Cache-Control: no-cache X-Request-Id: e28a5f7dc8b1a69bb11a3674de0af9ff X-Runtime: 0.013878 X-Rack-Cache: invalidate, pass X-Powered-By: Phusion Passenger 4.0.45 Set-Cookie: _bfx_session=BAh7BkkiD3Nlc3Npb25faWQGOgZFRkkiJTEwYjgyOTA5NGQwNDNhZDcyNGJmOGQ3YTUzYjFkZmExBjsAVA%3D%3D--bcc14b664c74ebb5d65b37e0963633864f961db1; domain=.bitfinex.com; path=/; expires=Wed, 27-Aug-2014 17:36:25 GMT; secure; HttpOnly X-Frame-Options: DENY Status: 400 Bad Request Connection: close Transfer-Encoding: chunked Content-Type: application/json; charset=utf-8 Set-Cookie: incap_ses_210_116519=9KL4BW+G93kyLfxbKxLqAhEQ/lMAAAAAvgWqMf1VSt0wDLjgR7/HVg==; path=/; Domain=.bitfinex.com Set-Cookie: visid_incap_116519=ac57kqaLQVOqmhvd0cvwbBEQ/lMAAAAAQUIPAAAAAAB7NOL1Q2OnwFzIstEBvzIl; expires=Fri, 26 Aug 2016 10:33:43 GMT; path=/; Domain=.bitfinex.com Set-Cookie: nlbi_116519=DXQaDeLHCXJSmY8hjO51AAAAAADmxnGxU+a7pkkC/HnN9rcI; path=/; Domain=.bitfinex.com X-Iinfo: 1-2354203-2354205 NNNY CT(137 137 0) RT(1409159185142 51) q(0 0 3 -1) r(3 5) U6 X-CDN: Incapsula

2014-08-27 12:06:23 LVL:2

Warning: Request resent due timeout

Ty! :) Is that what you need?

*edit: that text is huge on my screen. Not sure how to fix. Sry.

*Edit: trimmed to relevant output (I think)

JulyIghor commented 10 years ago

It ok, that what I need. I'll make fix and you confirm that it fixed. What the best way to test it for you? source code or windows binary?

xbrooks commented 10 years ago

I can test both. Windows QtBitcoinTrader runs under Wine with no problems and Linux version compiles with no problems, also. My partner prefers Windows.

JulyIghor commented 10 years ago

Can you confirm does [trade] works and [exchange] not?

xbrooks commented 10 years ago

Sorry for the delay! Busy busy lol

Tested. Yes, [trade] works, [exchange] does not. (Have not downloaded any new version)

JulyIghor commented 10 years ago

Thanks for replay. There was no changes made to bitfinex cpp classes. It is bitfinex server problem, auth requests for exchange always return error 400 Bad Gateway. You should open support ticket on bitfinex and it will helps fix it faster.

xbrooks commented 10 years ago

Let's hit them in triplicate. :D You, me, and my friend will open tickets asking them to fix! :dancers:

*edit: 2 tickets submitted! :D

xbrooks commented 10 years ago

[quote] Hello,

This problem seems to relate to an IP being blacklisted for some reason. I dont think it has to do with QtTrader

Could you give me your IP address (or the one of the server accessing our API) if the problem persists? I will try to whitelist it and see if it improves the response.

Thnak you

Best regards Raphael CTO Bitfinex team On Mon, 01 Sep 2014 15:37:15 +0700 [quote]

Msg me any IP addresses you would like me to submit.

JulyIghor commented 10 years ago

There is many people who reported this bug via email. And it not works for me too and I'm sure I don't used Bitfinex api at all, so I should be not banned and you too. And if they banned IP, it wired why it does works for "Exchange" and not works for "Trade".

JulyIghor commented 10 years ago

Problem was in Qt Bitcoin Trader, it send margin open order instead of limit order. Since you don't have margin balance it caused this error. Bitfinex bug was in response, it should return message "no balance for this order" etc, "Bad request" error confused me. ninobrooks, what is your OS? I'll give you test build, and you confirm that it fixed.

xbrooks commented 10 years ago

Let us test with windows. Linux second. Ty July. Glad you found the bug! On Sep 4, 2014 5:13 PM, "IGHOR" notifications@github.com wrote:

Problem was in Qt Bitcoin Trader, it send margin open order instead of limit order. Since you don't have margin balance it caused this error. Bitfinex bug was in response, it should return message "no balance for this order" etc, "Bad request" error confused me. ninobrooks, what is your OS? I'll give you test build, and you confirm that it fixed.

Reply to this email directly or view it on GitHub https://github.com/JulyIGHOR/QtBitcoinTrader/issues/154#issuecomment-54553088 .

JulyIghor commented 10 years ago

Check for update. Thanks for bug report.