JulyIghor / QtBitcoinTrader

Secure multi crypto exchange trading client
https://sourceforge.net/projects/bitcointrader/
732 stars 376 forks source link

Binance api fee is incorrect #239

Closed lookfirst closed 5 years ago

lookfirst commented 5 years ago

My fee is 0.075 and the UX reports that it is 0.1

Also cannot set it to 3 decimals in the UX (in the calculator)

JulyIghor commented 5 years ago

Qt Bitcoin Trader not yet supports different fees for maker and taker, so this is delayed. 3 decimals in the UX fixed now

lookfirst commented 5 years ago

I have the same fee for both, so that is fine. Just needed the 3 decimals.

lookfirst commented 5 years ago

@JulyIGHOR Fixed in the calculator, but not on the main screen:

image

JulyIghor commented 5 years ago

Please

@JulyIGHOR Fixed in the calculator, but not on the main screen:

image

Please open Debug dialog, catch few minutes traffic, save it to file and send here or to my email julyighor@gmail.com

lookfirst commented 5 years ago

Not fixed

Interestingly enough, I don't see the fee anywhere in the debug output.

Sorry, I won't send it to you since it has my account data in it.

lookfirst commented 5 years ago

I should add that when I close the debug window by clicking on the close icon, it reliably crashes the app.

lookfirst commented 5 years ago

image

I see the issue. I'm using BNB to pay for my fees, which lowers them to 0.075, so that is why it is not showing up in your app correctly.

JulyIghor commented 5 years ago

Sorry, I won't send it to you since it has my account data in it.

There should be no account data, if you can find it there, let me know which kind it is and we will fix it.

I should add that when I close the debug window by clicking on the close icon, it reliably crashes the app.

Thanks for bug report.

Qt Bitcoin Trader takes fee value from API and info looks like this:

{
"makerCommission":10,
"takerCommission":10,
"buyerCommission":0,
"sellerCommission":0,
"canTrade":true,
"canWithdraw":true,
"canDeposit":true,
"updateTime":1531843000000,
"balances":[]
}

If you can find another values that contains your fee 0.075 in Debug log, please send this part of code and we will try to fix it.

lookfirst commented 5 years ago

I doubt it is in the API. The key here is to just allow me to check a box saying that I'm using BNB to pay for my fees. This will lower the fee by the current 25%.

https://support.binance.com/hc/en-us/articles/115000583311

JulyIghor commented 5 years ago

If someone know how to fix it with their API, let me know and fix will be added

lookfirst commented 5 years ago

@JulyIghor The way to fix it is to hardcode the value for now. It isn't in their api.