search

JulyWitch / animated_snack_bar

Easily show beautiful snack bars directly using overlays. Create custom snack bars and show them with awesome animations.
https://pub.dev/packages/animated_snack_bar
GNU General Public License v3.0
16 stars 12 forks source link

Flutter 3 compatibility #1

Closed JanRegent closed 2 years ago

JanRegent commented 2 years ago

/C:/Android/flutter/.pub-cache/hosted/pub.dartlang.org/animated_snack_bar-0.2.1/lib/src/animated_snack_bar.dart:114:20: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

Limitless-Kode commented 2 years ago

Are we getting a fix for this anytime soon? @JulyWitch

farhantandia commented 2 years ago

just delete "!" inside WidgetsBinding.instance!.addPostFrameCallback( -> WidgetsBinding.instance.addPostFrameCallback(

Limitless-Kode commented 2 years ago

@JulyWitch that is in your library isn't it best if you make that change and update the package? I don't think it's a good idea to update your package code.

farhantandia commented 2 years ago

I think its okay only for warning issue @Limitless-Kode

Limitless-Kode commented 2 years ago

@JanRegent would you mind if I create a pull request to fix the warning? And maybe collaborate with you to add more features to it. Allowing users to change the snackbar colors, icons and border-radius would make this package the best on pub.dev.

JulyWitch commented 2 years ago

@JanRegent would you mind if I create a pull request to fix the warning? And maybe collaborate with you to add more features to it. Allowing users to change the snackbar colors, icons and border-radius would make this package the best on pub.dev.

Sorry for my late reply, Feel free to raise pull requests

JulyWitch commented 2 years ago

@Limitless-Kode I have merged your PR and updated the package (v0.2.2), I will close this issue