search

JumboCode / TUTV

JumboCode project for TUTV, currently led by Frank Ma. Led by Deepanshu Utkarsh 2019 - 2020.
4 stars 0 forks source link

Break down the main equipment dashboard into React components #15

Closed duci9y closed 4 years ago

duci9y commented 4 years ago

This is a rough sketch of our main dashboard:

2 Main Dashboard

Consider what else may be required on this page as a laid out React component, eg. a header/footer? Feel free to consult @emai-lai if in doubt. Then, using a simple app like Preview (on Mac) or Paint (Windows), draw rectangles around visual elements that will probably need to be components.

I am thinking a sidebar vs. main content component division could be useful, just a suggestion.

  1. Create an issue specifically for the calendar component tree, which you probably don't need to break down too much. Assign this to @kmoran04, who will decide whether to use a third party component or build our own from scratch.

  2. Break down the rest of the page into slightly more detailed component trees, but not too much. Create an issue for this containing your updated sketch and assign it to @erenaci and @isabellau. They will implement basic scaffolding for those component trees in code.

Note: These are still rough sketches. Don't worry about being 'wrong' about something.

kmoran04 commented 4 years ago

Do the red crossed out tabs mean I shouldn't create a component for them?

duci9y commented 4 years ago

Yup, that’s correct.

On Oct 15, 2019, at 11:53 PM, kmoran04 notifications@github.com wrote:

 Do the red crossed out tabs mean I shouldn't create a component for them?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

kmoran04 commented 4 years ago

Also these are just React functional components, not styled components, correct?

duci9y commented 4 years ago

Yup! No CSS styles yet. Or did you mean something else by “styled”?

On Oct 16, 2019, at 12:01 AM, kmoran04 notifications@github.com wrote:

 Also these are just React functional components, not styled components, correct?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

kmoran04 commented 4 years ago

styled-components is a React package that lets you treat a styled element like a component, so like <IconTitle> text </IconTitle> would be just text with added styling and it isn't a functional component, but it is a component technically

duci9y commented 4 years ago

Ah. Looked into it. It does not look suitable for our project, so let’s stick to functional components.

On Oct 16, 2019, at 12:04 AM, kmoran04 notifications@github.com wrote:

 styled-components is a React package that lets you treat a styled element like a component, so like text would be just text with added styling and it isn't a functional component, but it is a component technically

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.