search

JumboCode / TUTV

JumboCode project for TUTV, currently led by Frank Ma. Led by Deepanshu Utkarsh 2019 - 2020.
4 stars 0 forks source link

Introduce react-router #24

Closed controversial closed 5 years ago

controversial commented 5 years ago

This PR adds a basic react-router setup with a couple of routes. The routes are not intended to necessarily have the same URL pattern as the final app, but to serve as an example for how routing might work for a few routes of an app like TUTV.

Closes #17

controversial commented 5 years ago

Documentation completed at https://github.com/JumboCode/TUTV/wiki/Routing-with-react-router. This documentation reflects the current state of the PR, including decisions about file structure etc, which are not necessarily intended to be final. I'll update the docs if anything changes here.

controversial commented 5 years ago

Yeah, let’s do that. I’ll move it

On Tue, Oct 22, 2019 at 12:39 PM Deepanshu Utkarsh notifications@github.com wrote:

@duci9y commented on this pull request.

In src/frontend/src/pages/Home.tsx https://github.com/JumboCode/TUTV/pull/24#discussion_r337627370:

+import React from 'react'; + +const Home: React.FC = () => {

  • return (

  • Home page

  • ); +};

  • +export default Home;

    • Maybe this should also be in its own folder to ensure consistency? Thoughts?

    — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JumboCode/TUTV/pull/24?email_source=notifications&email_token=ACPFRL5L42I5QHLXOQDBBDLQP4UFVA5CNFSM4JCQJFZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIZUNOY#pullrequestreview-305350331, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPFRLZZO6TPMEY46KDXTVLQP4UFVANCNFSM4JCQJFZA .

    controversial commented 5 years ago

    I moved the Home page component into its own folder