search

JumboCode / TUTV

JumboCode project for TUTV, currently led by Frank Ma. Led by Deepanshu Utkarsh 2019 - 2020.
4 stars 0 forks source link

The Request Summary page should display a loading indicator while waiting for data #55

Closed duci9y closed 4 years ago

duci9y commented 4 years ago

Because it takes too long on first load sometimes. Try using an existing implementation.

controversial commented 4 years ago

Closed by #56

duci9y commented 4 years ago

We still should have a loading indicator because a fresh load of the page ends up taking ~12 seconds on Heroku.

controversial commented 4 years ago

I think this is because of the way I'm hosting the mock API  – if nobody queries the mock API for a long time Zeit "freezes" the server and it takes a while to start back up the next time someone makes a query. I can take a little time soon to move it to a "now v2" deployment that wouldn't have that problem. In any case, I don't think our API will have 12-second response times, but I can build a loader if it turns out to be an issue once we're using the real API.

My only hesitation to implement it now is that if it turns out the API request takes like <0.5 seconds, the appearance of a loading state could be jarring