Add image and description to EquipmentItem

[71c]

Added image and description fields to EquipmentItem. Also replaced string concatenation with f-strings in server/api/models.py. Closes #50

[duci9y]

static is the URL where files inside the staticfiles directory get mounted.

Deepanshu

On Feb 26, 2020, at 4:18 PM, Luke Deen Taylor notifications@github.com wrote:

 @controversial approved this pull request.

Looks good overall

In server/tutvwebsite/settings/base.py:

]

-WHITENOISE_INDEX_FILE = True

-django_heroku.settings(locals()) +STATIC_URL = '/static/' +STATIC_ROOT = os.path.join(BASE_DIR, "staticfiles") It might be good to rename "static" and "staticfiles" to something more descriptive of what their separate purposes are - right now I'm not sure that if I were looking for a certain file, I'd be able to guess whether it lived in "static" or "staticfiles" without reading through a lot of the code.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

[controversial]

Why isn’t that directory just called static?

On Wed, Feb 26, 2020 at 4:48 PM Deepanshu Utkarsh notifications@github.com wrote:

static is the URL where files inside the staticfiles directory get mounted.

Deepanshu

On Feb 26, 2020, at 4:18 PM, Luke Deen Taylor notifications@github.com wrote:

 @controversial approved this pull request.

Looks good overall

In server/tutvwebsite/settings/base.py:

]

-WHITENOISE_INDEX_FILE = True

-django_heroku.settings(locals()) +STATIC_URL = '/static/' +STATIC_ROOT = os.path.join(BASE_DIR, "staticfiles") It might be good to rename "static" and "staticfiles" to something more descriptive of what their separate purposes are - right now I'm not sure that if I were looking for a certain file, I'd be able to guess whether it lived in "static" or "staticfiles" without reading through a lot of the code.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/JumboCode/TUTV/pull/62?email_source=notifications&email_token=ACPFRL5LNBWHFPNLFCDRQTTRE3PUTA5CNFSM4KZ72QI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENCAVUQ#issuecomment-591661778, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPFRL6JPUW6JRXDQANQAUDRE3PUTANCNFSM4KZ72QIQ .

[duci9y]

I think it would probably be more confusing than it already is based on your first comment :) but also that’s the default name.

Deepanshu

On Feb 26, 2020, at 5:09 PM, Luke Deen Taylor notifications@github.com wrote:

Why isn’t that directory just called static?

On Wed, Feb 26, 2020 at 4:48 PM Deepanshu Utkarsh notifications@github.com wrote:

static is the URL where files inside the staticfiles directory get mounted.

Deepanshu

On Feb 26, 2020, at 4:18 PM, Luke Deen Taylor notifications@github.com wrote:

 @controversial approved this pull request.

Looks good overall

In server/tutvwebsite/settings/base.py:

]

-WHITENOISE_INDEX_FILE = True

-django_heroku.settings(locals()) +STATIC_URL = '/static/' +STATIC_ROOT = os.path.join(BASE_DIR, "staticfiles") It might be good to rename "static" and "staticfiles" to something more descriptive of what their separate purposes are - right now I'm not sure that if I were looking for a certain file, I'd be able to guess whether it lived in "static" or "staticfiles" without reading through a lot of the code.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/JumboCode/TUTV/pull/62?email_source=notifications&email_token=ACPFRL5LNBWHFPNLFCDRQTTRE3PUTA5CNFSM4KZ72QI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENCAVUQ#issuecomment-591661778, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPFRL6JPUW6JRXDQANQAUDRE3PUTANCNFSM4KZ72QIQ .

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.