JumboCode / casa-myrna

JumboCode 2023-2024 project for Casa Myrna, led by Elizabeth Foster
https://casa-myrna-pumv.vercel.app
4 stars 0 forks source link

Dev 11 close choose filters modal #177

Closed pmelga01 closed 4 months ago

pmelga01 commented 4 months ago

Developer: Pam and Carly Dates: April 23rd 2024 Time spent: 1.5 hours Summary: Filters popup component closes (without the need of refresh), cleaned mobile view grid vs. desktop view grid, fixed dropdown list to pop out cleaner out of Select component, added storing state of selected employee, connected to backend employee names.

Before

Before

After

After 1 After 2 After 3

Testing Mobile:

Before

Before Mobile

After

After Mobile 1 After Mobile 2 After Mobile 3

Reflection: The ticket was extremely straightforward, it was just a matter of changing the onClose function into to a much less complicated function, basically copy the way modals closing are handled just like everywhere else in the code ;-;.

Also, I noticed that the filters for Employee Names was not synced up to the backend and were random names, so to compensate I had an idea of just re-using the ComboBox component that Naomi and I wrote up in a previous ticket, also modularizing it a bit to accommodate for the styling differences! It worked perfect! Only thing is that the calendar does not react to any name filters at the moment!

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
casa-myrna ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 8:44pm
safe-link ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 8:44pm