search

Jumoo / uSync.Complete.Issues

Public Issue tracker and roadmap for uSync.Complete
https://jumoo.co.uk/usync/complete/
2 stars 1 forks source link

Usync complete can't synchronised not-published nodes correctly #221

Open bielu opened 5 months ago

bielu commented 5 months ago

Describe the bug Bug is related to synchronization of unpublished content, which was never published.

Version (please complete the following information):

To Reproduce Steps to reproduce the behavior: 1.Create node, add block editor, add content, save but not publish

  1. try to synchronised it to other server

Current result Node was created in other server, but was missing all properties!

Expected behavior Node is created in other server with all properties.

KevinJump commented 5 months ago

Hi,

It is a bug, but the other wat around - uSync.Publisher only syncronised published content, so ideally the default behavior would be the item does not get published at all.

i think what is happening is that our PublishedContentHandler, does only deal in published values, but it is syncing the undering content item, and then not setting the properies, ideally it should not publish the item!

(you can in theory change the behavior of uSync.Publisher by swapping out the PublishedContentHandler for the normal 'contentHandler' in config - i can dig that out if you need it).

bielu commented 5 months ago

HI Kevin, if you can dig out this, it would be great!

bielu commented 5 months ago

@KevinJump did you had chance to look and fit bit of configuration which you mentioned?

KevinJump commented 5 months ago

Hi,

yeah sorry. settings below.

  "uSync": {
    "Publisher": {
      "Handlers": {
        "DisabledHandlers": [
          "PublishedContentHandler",
          "ContentTemplateHandler"
        ]
      },
      "Settings": {
        "IncomingEnabled": true,
        "AppId": "YOUR-APP-ID-HERE",
        "AppKey": "YOUR-APP-KEY-HERE"
      }
    }
  }

So the default (when this isn't set) is to disable the content Handler and ContentTemplateHandler, so the "PublishedContentHandler" manages the content, this swaps that back.

the diffrence between the two handlers is small. PublishedHandelr uses the PublishedValue Content handler uses the EditedValue

marcemarc commented 5 days ago

Suggestion for when using the PublishedContentHandler, and there are later changes saved for the node, that it would be good to report a warning: "Content includes Unpublished Changes, which have not been transferred"

The editor confusion is in the message "Completed without any issues at all, nothing to worry about here"

Not sure if empty nodes should be created though.