Jumoo / uSync.Complete.Issues

Public Issue tracker and roadmap for uSync.Complete
https://jumoo.co.uk/usync/complete/
2 stars 1 forks source link

Language support #85

Closed loriRyanp closed 3 years ago

loriRyanp commented 3 years ago

Ive updated several document Types locally to turn on the Allow varying by culture. I now need to import in just the settings to a "UAT" db however when I do just import the setting it doesnt appear to be getting updated.

When I choose to update the content and the settings it does.

Is there a way to just update the doctypes Allow varying by culture without affecting the content?

Any help would be brill.

KevinJump commented 3 years ago

Hi,

We need to look into this, but i have seen similar before (not with uSync) on some versions of v8 - if you change a doctype to vary by culture, Umbraco doesn't necessarily update the content to then put the values into the correct language elements (at least not in the database) we have code in the core uSync to cater for this on import, because the default values actually remain with no culture even though the content should have cultured values

i think maybe we might need to apply a similar fix on export so non-cultured values are infact copied to a default culture (if that is missing) - but this behavior can be a little odd. we might say, changing to vary by culture requires a content sync

KevinJump commented 3 years ago

Hi -

I've been looking at this today - at the moment i can't quite recreate the issue.

so i have done the following:

  1. got two sites in sync without varying by culture
  2. updated a doctype to vary by culture
  3. also updated some properties on that doctype to vary by culture
  4. published just the settings to the other site*.

when i do this and look on the target site the content is in the default (en-us) language as expected ?

this was on latest Umbraco/uSync - more than willing to try on another version -

*noticed there is an issue syncing languages on uSync.Complete 8.9 - but this doesn't effect the default language stuff.

loriRyanp commented 3 years ago

Hi Kevin So I have one site that doesn’t have varying by culture.

Ive update a base site – that has all the doctypes with the varying by culture flags – along with the properties.

We have multi sites that inherit the same code base but varying content.

The problem is I need to update the site that doesn’t have multilingual on to have multilingual.

If I could assign the content on the base site to a language say en-ie (is that possible?), update the doctypes via a sync without content with the varying by culture flag would that work? Am using usync complete 8.9 and umbraco version 8.6.4 Kindest Regards Lori

KevinJump commented 3 years ago

OK, I will have a look on v8.6.4 of umbraco. that sounds very similar to what i just tried on a fresh install (Umbraco v8.11.1) - but i will double check and install v v8.6.4 site and see if i can see any diffrences.

KevinJump commented 3 years ago

Some results of testing:

v8.11.1 variants-Eight11One

v8.6.4: (same thing) variants-eightsixfour

Just to confirm is this what you are expecting to happen ? (indeed does this happen when you do it? there might be another issue somewhere 😞 )

or do you want the content in all variants ? - (in these examples it goes into the default language)

loriRyanp commented 3 years ago

Thanks am just completely documenting to confirm with one page

From: Kevin Jump notifications@github.com Sent: Tuesday 9 February 2021 11:51 To: Jumoo/uSync.Complete.Issues uSync.Complete.Issues@noreply.github.com Cc: Lori Ryan lori.ryan@progress.ie; Author author@noreply.github.com Subject: Re: [Jumoo/uSync.Complete.Issues] Language support (#85)

Caution: This email originated from outside of Progress Systems. Do not click links or open attachments unless you recognise the sender and know that the content is safe.

OK, I will have a look on v8.6.4 of umbraco. that sounds very similar to what i just tried on a fresh install (Umbraco v8.11.1) - but i will double check and install v v8.6.4 site and see if i can see any diffrences.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Jumoo/uSync.Complete.Issues/issues/85#issuecomment-775882565, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOIOEBHPOUVMA5O3MS5BWZTS6EORXANCNFSM4XFRUXXA.

The information in this e-mail and any attachments is proprietary and/or confidential. Unless you are the intended recipient or his/her representative you are not authorised to, and must not, read, copy, distribute, use or retain this message or any part of it. If you are not the intended recipient, please notify the sender immediately, delete the material from any system and destroy any copies. Communications to/from Progress Systems Limited are monitored and are subject to archiving and review by persons other than the intended recipient. Whilst all reasonable care has been taken to avoid the transmission of viruses, it is the responsibility of the recipient to ensure that the opening, use or onward transmission of this message and any attachments will not adversely affect its systems or data. No responsibility is accepted by any member of Progress Systems Limited in this regard and the recipient should carry out such virus and other checks as it considers appropriate. Progress Systems Limited is not liable for any personal views of the sender.

Progress Systems Limited | Company Reg. No. 193329 | Registered address: 163 Lower Kimmage Road, Kimmage, Dublin 6W, D6W F512, Ireland. Progress Software Systems Limited | Company Reg. No. 06032993 | Registered address: 960 Capability Green, Luton, LU1 3PE, United Kingdom.

KevinJump commented 3 years ago

Hi,

this is fixed in 8.9.1 (Just released)