Jumoo / uSyncMigrations

Rough and ready migration code.
Mozilla Public License 2.0
44 stars 57 forks source link

Phase 4.1 doesn't seem to be running all the migrators #245

Closed stevetemple closed 9 months ago

stevetemple commented 9 months ago

After many hours of pulling my hair out trying to get a custom migrator working, I've realised that version phase 4.1 isn't converting any content using the migrators, it's doing the ContentTypes but not actual content values. It wasn't just my migrator but all of them not updating the content values.

Rolling back to an older version (3) and it's working correctly now

KevinJump commented 9 months ago

:( do you want to send me over the uSync files ? - the code is running migrators for me, but it might be something its missing.

I am doing some migrator work today, so i could take a look see if there is fixes.

KevinJump commented 9 months ago

OK, Stupid error no 412.

Since we split it all up - The uSync.Migrations.Migrator package is not listed as a depenency of uSync.Migrations.

so on a clean install you get no migrators !

fix done. will push a new version later.

stevetemple commented 9 months ago

It's a bit interesting because I'd downloaded the repo and included the migrators in the project directly. I could see it was running the GetConfigValues method but not the GetContentValue methods. So might be something else also going on.

ProNotion commented 9 months ago

That might also explain the issue I am seeing here

stevetemple commented 9 months ago

Yeah I think so, it's something in the code that now allows per property migrators is now not including the general migrators. I'll try and dig in further.

It's a lot higher in the stack than the actual place where it should be calling GetContentValue. More in the setup of the migrators

ProNotion commented 9 months ago

I'm still trying to unravel this but the list of DataType aliases in the ContentTypeMigrationContext all have empty values which is quite possibly related.

stevetemple commented 9 months ago

That looks promising

stevetemple commented 9 months ago

That looks like it's fixed it when I run it now, good spot on that one @ProNotion

stevetemple commented 9 months ago

This is fixed in latest source